Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null reference exception #2966

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

dracan
Copy link
Contributor

@dracan dracan commented Dec 29, 2022

This has been seen multiple times when using bUnit tests. For more information, see #2956.

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2956

💡 Background and solution

Detailed in the above-mentioned ticket.

📝 Changelog

Fix periodic null reference exception when testing input component using the bUnit testing library.

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

This has been seen multiple times when using bUnit tests. For more information, see ant-design-blazor#2956.
@github-actions
Copy link

github-actions bot commented Dec 29, 2022

@dnfadmin
Copy link

dnfadmin commented Dec 29, 2022

CLA assistant check
All CLA requirements met.

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 43.64% // Head: 43.67% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (c4ca145) compared to base (9067a68).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2966      +/-   ##
==========================================
+ Coverage   43.64%   43.67%   +0.03%     
==========================================
  Files         551      551              
  Lines       25937    25937              
  Branches      263      263              
==========================================
+ Hits        11320    11329       +9     
+ Misses      14577    14568       -9     
  Partials       40       40              
Impacted Files Coverage Δ
components/input/Input.cs 68.88% <100.00%> (ø)
components/core/Component/Overlay/Overlay.razor.cs 73.83% <0.00%> (-1.75%) ⬇️
components/date-picker/locale/DatePickerLocale.cs 100.00% <0.00%> (+3.22%) ⬆️
components/locale-provider/LocaleProvider.cs 66.66% <0.00%> (+12.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 9f7964e into ant-design-blazor:master Dec 29, 2022
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
This has been seen multiple times when using bUnit tests. For more information, see ant-design-blazor#2956.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequent (but not every time) exception when disposing Input component (seen via bUnit tests)
3 participants