Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tabs): render issues #2967

Merged
merged 2 commits into from
Dec 29, 2022
Merged

fix(module: tabs): render issues #2967

merged 2 commits into from
Dec 29, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • Cancel the use of ShouldRender to control rendering
  • We may need to re-tune performance issues later

📝 Changelog

Language Changelog
🇺🇸 English Fixed some issues with dynamic rendering
🇨🇳 Chinese 修复一些关于动态渲染的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Dec 29, 2022

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 45.03% // Head: 43.58% // Decreases project coverage by -1.45% ⚠️

Coverage data is based on head (0919998) compared to base (9f7964e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2967      +/-   ##
==========================================
- Coverage   45.03%   43.58%   -1.46%     
==========================================
  Files         551      551              
  Lines       25933    25920      -13     
  Branches      263      263              
==========================================
- Hits        11680    11296     -384     
- Misses      14213    14584     +371     
  Partials       40       40              
Impacted Files Coverage Δ
components/tabs/TabPane.razor.cs 64.40% <ø> (-6.65%) ⬇️
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 23.07% <0.00%> (-53.85%) ⬇️
components/form/Form.razor.cs 38.88% <0.00%> (-29.63%) ⬇️
components/form/FormItem.razor.cs 46.54% <0.00%> (-28.94%) ⬇️
components/core/Base/AntInputComponentBase.cs 59.04% <0.00%> (-21.91%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit d852ed4 into master Dec 29, 2022
@ElderJames ElderJames deleted the fix/tabs-render-issue branch December 29, 2022 15:24
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
…zor#2967)

* fix(module: tabs): render issues

* remove change avoiding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant