Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: input): OnChange would trigger three times and clear icon would cover the suffix #2970

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2969

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Dec 30, 2022

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Base: 45.00% // Head: 43.57% // Decreases project coverage by -1.42% ⚠️

Coverage data is based on head (a860a00) compared to base (d852ed4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2970      +/-   ##
==========================================
- Coverage   45.00%   43.57%   -1.43%     
==========================================
  Files         551      551              
  Lines       25916    25918       +2     
  Branches      263      263              
==========================================
- Hits        11664    11295     -369     
- Misses      14212    14583     +371     
  Partials       40       40              
Impacted Files Coverage Δ
components/core/Base/AntInputComponentBase.cs 59.81% <100.00%> (-21.14%) ⬇️
components/input/Input.cs 68.79% <100.00%> (-0.44%) ⬇️
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 23.07% <0.00%> (-53.85%) ⬇️
components/form/Form.razor.cs 38.88% <0.00%> (-29.63%) ⬇️
components/form/FormItem.razor.cs 46.54% <0.00%> (-28.94%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit da86abd into master Dec 31, 2022
@ElderJames ElderJames deleted the fix/input-onchange-clear-icon branch December 31, 2022 07:28
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
…on would cover the suffix (ant-design-blazor#2970)

* fix(module: input): `OnChange` would trigger three times and clear icon would cover the suffix

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The input component OnChange event fires twice
1 participant