-
-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feet-bug(module: Transfer): refresh data on change SelectedKeys or TargetKeys parameters #2977
feet-bug(module: Transfer): refresh data on change SelectedKeys or TargetKeys parameters #2977
Conversation
…nges of the parameter.
Codecov ReportBase: 45.03% // Head: 44.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2977 +/- ##
==========================================
- Coverage 45.03% 44.99% -0.04%
==========================================
Files 551 551
Lines 25915 25925 +10
Branches 263 263
==========================================
- Hits 11671 11666 -5
- Misses 14204 14219 +15
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for contribution @Magehernan ! I think it would be better to refrsh data in the setter of these parameters. |
We also need to implement two-way binding, which is to update the external |
I try but the problem is it need all the other parameter set for it to work, so for it to work it needed a flag for set initialized and then OnInitialized call Refresh... When i do this, it call Refresh 2 times and with this implementation only is called 1 so more efficient. Let me know what you think.
i can try, let me know if you prefer all on this pull request or the two-binding in another. |
I almost sure that it will be fix because i am doing async request to the server for fill the targetKeys and i was having that problem that the targetkeys don't appear and with this it was fixed, but maybe there is another case. |
I added reinitializacion of values when TargetKeys or SelectedKeys change from outside so it properly display the correct values.
I am using this in production and works fine, and is more easy to use this way. I hope it helps.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge