Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tabs): avoid active pane after tabs is dispsed #2981

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2180

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix avoid active pane after tabs is dispsed
🇨🇳 Chinese 修复 Tabs 关闭异常,阻止在 disposed 后还触发渲染器

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 45.03% // Head: 43.58% // Decreases project coverage by -1.44% ⚠️

Coverage data is based on head (bc761a6) compared to base (a2fbb93).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head bc761a6 differs from pull request most recent head d6b63d4. Consider uploading reports for the commit d6b63d4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2981      +/-   ##
==========================================
- Coverage   45.03%   43.58%   -1.45%     
==========================================
  Files         551      551              
  Lines       25915    25922       +7     
  Branches      263      263              
==========================================
- Hits        11671    11299     -372     
- Misses      14204    14583     +379     
  Partials       40       40              
Impacted Files Coverage Δ
components/tabs/Tabs.razor.cs 70.37% <100.00%> (-0.42%) ⬇️
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 23.07% <0.00%> (-53.85%) ⬇️
components/form/Form.razor.cs 38.88% <0.00%> (-29.63%) ⬇️
components/form/FormItem.razor.cs 46.54% <0.00%> (-28.94%) ⬇️
components/core/Base/AntInputComponentBase.cs 59.81% <0.00%> (-21.50%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit bd89940 into master Jan 5, 2023
@ElderJames ElderJames deleted the fix/tabs-dispose-active-tab branch January 5, 2023 07:59
kooliokey pushed a commit to kooliokey/ant-design-blazor that referenced this pull request Jan 15, 2023
…n-blazor#2981)

* fix(module: tabs): avoid active pane after tabs is dispsed

* clear lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs component is trying to render content when disposing
1 participant