fix(module: select): add tags when datasource is empty #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportBase: 43.61% // Head: 44.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2986 +/- ##
==========================================
+ Coverage 43.61% 44.99% +1.37%
==========================================
Files 551 551
Lines 25923 25913 -10
Branches 263 263
==========================================
+ Hits 11306 11659 +353
+ Misses 14577 14214 -363
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ElderJames
reviewed
Jan 6, 2023
ElderJames
approved these changes
Jan 8, 2023
pr-triage
bot
added
PR: merged
PR: reviewed-approved
and removed
PR: reviewed-approved
PR: merged
labels
kooliokey
pushed a commit
to kooliokey/ant-design-blazor
that referenced
this pull request
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fixes #2965
💡 Background and solution
When there was a select component set to
Tagsmode and the datasource was empty, any entered tag options were being hidden from user even though they went through the two way binding.There was an issue where whenever the datasource was empty it would use
Clear()on the option list instead of letting the change trickle down to where it updates the option list based on the datasource. To ensure the user entered tags do not go away I add them after the option list is created.📝 Changelog
☑️ Self Check before Merge