Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Calendar. #1763 fixed #3087

Merged

Conversation

agolub-s
Copy link
Contributor

@agolub-s agolub-s commented Feb 10, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#1763

💡 Background and solution

Improve user expirience with DatePicker.

  1. Add commit changes after blur in input of DatePicker.
  2. Fix click on suffix icon in DatePickerInput.

📝 Changelog

Add commit changes after blur in Calendar.
Fix click on suffix icon in DatePickerInput.

Language Changelog
🇺🇸 English Add commit changes after blur in Calendar. Fix click on suffix icon in DatePickerInput.
🇨🇳 Chinese 在日历中模糊后添加提交更改。修复单击DatePicker输入中的后缀图标。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Feb 10, 2023

@agolub-s agolub-s changed the title Feature/improve date picker Improve Calendar. #1763 fixed Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Patch coverage: 95.45% and project coverage change: +0.14% 🎉

Comparison is base (f9b8800) 46.67% compared to head (8a89170) 46.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #3087      +/-   ##
===========================================
+ Coverage    46.67%   46.81%   +0.14%     
===========================================
  Files          558      558              
  Lines        26946    26965      +19     
  Branches       267      267              
===========================================
+ Hits         12576    12624      +48     
+ Misses       14330    14301      -29     
  Partials        40       40              
Files Changed Coverage Δ
...ponents/date-picker/internal/DatePickerInput.razor 91.66% <ø> (ø)
components/date-picker/internal/DatePickerBase.cs 80.92% <88.88%> (+1.45%) ⬆️
components/date-picker/DatePicker.Razor.cs 81.52% <100.00%> (-0.94%) ⬇️
components/date-picker/RangePicker.razor.cs 70.97% <100.00%> (+4.95%) ⬆️
components/date-picker/locale/FormatAnalyzer.cs 90.59% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agolub-s
Copy link
Contributor Author

Hello, is anyone here?

@ElderJames
Copy link
Member

Hello @agolub-s , please sign the CLA.

@agolub-s
Copy link
Contributor Author

agolub-s commented May 17, 2023

@dotnet-policy-service agree company="Quirco"

@agolub-s
Copy link
Contributor Author

Hello @agolub-s , please sign the CLA.

Hello, James.

I signed CLA. Thanks for help with my merge requests.
Should I to do something with it?

@agolub-s
Copy link
Contributor Author

agolub-s commented Jun 5, 2023

@ElderJames Hi, did you check it?

@ElderJames
Copy link
Member

Yes,I will. The tests was fail and need to be fixed.

@agolub-s
Copy link
Contributor Author

agolub-s commented Jul 3, 2023

@ElderJames Hi, sorry for my late, I fixed tests. And can you check this request, please, #3120

@SumitAngra
Copy link

@agolub-s Is there anything pending on this PR to complete ?

@agolub-s
Copy link
Contributor Author

@agolub-s Is there anything pending on this PR to complete ?

I don't know(

@SumitAngra
Copy link

@agolub-s Thanks for your response.
I can see a few review comments on the PR added by james yesterday :)
Hoping to get this PR merged soon!

@agolub-s
Copy link
Contributor Author

@ElderJames Thanks for your response, I fixed it.

Could you check this merge request, please? #3120

@agolub-s
Copy link
Contributor Author

@agolub-s Is there anything pending on this PR to complete ?

Thank you so much, I waiting this merge request too much, I hope it will be soon)

@ElderJames
Copy link
Member

@agolub-s Thank you, this PR is ready to merge.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ElderJames ElderJames changed the base branch from master to feature August 15, 2023 15:04
@ElderJames ElderJames merged commit b329aa6 into ant-design-blazor:feature Aug 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants