Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tabs): animated cause display incorrectly #3177

Merged
merged 3 commits into from Apr 9, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3143
fixed #3174

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fixed Tabs animated cause display incorrectly
🇨🇳 Chinese 修复 Tabs 的 Animated 属性导致显示不正常

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Mar 13, 2023

@ElderJames ElderJames force-pushed the fix/tabs-animated-cause-display-issue branch from 424fcda to e36829a Compare April 8, 2023 07:03
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (c2599eb) 46.08% compared to head (e36829a) 46.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
+ Coverage   46.08%   46.13%   +0.04%     
==========================================
  Files         556      557       +1     
  Lines       26653    26630      -23     
  Branches      264      266       +2     
==========================================
+ Hits        12284    12285       +1     
+ Misses      14329    14305      -24     
  Partials       40       40              
Impacted Files Coverage Δ
components/tabs/TabPane.razor 85.00% <ø> (ø)
components/tabs/Tabs.razor 56.25% <ø> (ø)
components/tabs/Tabs.razor.cs 70.63% <ø> (-0.11%) ⬇️
components/tabs/TabPane.razor.cs 67.69% <100.00%> (+3.28%) ⬆️

... and 33 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 1b3625e into master Apr 9, 2023
6 checks passed
@ElderJames ElderJames deleted the fix/tabs-animated-cause-display-issue branch April 9, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs open animation causes Content to be lost Tabs Animated Seems
1 participant