Add EditorConfig for naming conventions #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vertonghenb
commented
Mar 22, 2020
•
vertonghenb
commented
- Invalid Property Naming convention will now throw an error instead of a warning, which will act like a Linter. However the build will still succeed on the GitHub workflow and locally(with errors) due to this issue that has to be resolved by Microsoft
- Disabled the XML comments, it's handy but not always needed at this point.
- Invalid Property Naming convention will now throw an error instead of a warning, which will make it impossible to build locally (usage as a Linter). However the build will still succeed on the GitHub workflow due to [this issue that has to be resolved by Microsoft](dotnet/roslyn#33558) - Disabled the XML comments, it's handy but not always needed at this point.
vertonghenb
changed the title
|
Finished, the build cannot be stopped using this linter but the error is more clear now. |
2 tasks
ElderJames
pushed a commit
that referenced
this pull request
Oct 15, 2020
- Invalid Property Naming convention will now throw an error instead of a warning, which will make it impossible to build locally (usage as a Linter). However the build will still succeed on the GitHub workflow due to [this issue that has to be resolved by Microsoft](dotnet/roslyn#33558) - Disabled the XML comments, it's handy but not always needed at this point. Co-authored-by: Benjamin Vertonghen <benjamin.vertonghen@apped.be>
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
- Invalid Property Naming convention will now throw an error instead of a warning, which will make it impossible to build locally (usage as a Linter). However the build will still succeed on the GitHub workflow due to [this issue that has to be resolved by Microsoft](dotnet/roslyn#33558) - Disabled the XML comments, it's handy but not always needed at this point. Co-authored-by: Benjamin Vertonghen <benjamin.vertonghen@apped.be>
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
- Invalid Property Naming convention will now throw an error instead of a warning, which will make it impossible to build locally (usage as a Linter). However the build will still succeed on the GitHub workflow due to [this issue that has to be resolved by Microsoft](dotnet/roslyn#33558) - Disabled the XML comments, it's handy but not always needed at this point. Co-authored-by: Benjamin Vertonghen <benjamin.vertonghen@apped.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.