Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tree): Fix search crash issue after Tree custom SearchExpression #3274

Merged

Conversation

ruyisee
Copy link
Contributor

@ruyisee ruyisee commented May 26, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • Tree自定义SearchExpression后Title中不包括过滤内容导致的bug
  • 判断要匹配字符串在Title内的index,只有 index>-1才做匹配高亮

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented May 26, 2023

@ruyisee ruyisee changed the title 修复Tree自定义SearchExpression后Title中不包括过滤内容导致的bug fix(module: tree): 修复Tree自定义SearchExpression后搜索崩溃问题 May 26, 2023
@ruyisee ruyisee changed the title fix(module: tree): 修复Tree自定义SearchExpression后搜索崩溃问题 fix(module: tree): Fix search crash issue after Tree custom SearchExpression May 27, 2023
@ruyisee
Copy link
Contributor Author

ruyisee commented May 27, 2023

@dotnet-policy-service agree

@ElderJames
Copy link
Member

Thanks for contribution @ruyisee , please chekout the review commonts.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.43 🎉

Comparison is base (61bfb03) 45.27% compared to head (852c517) 46.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3274      +/-   ##
==========================================
+ Coverage   45.27%   46.70%   +1.43%     
==========================================
  Files         557      557              
  Lines       26725    26731       +6     
  Branches      266      266              
==========================================
+ Hits        12100    12485     +385     
+ Misses      14585    14206     -379     
  Partials       40       40              
Impacted Files Coverage Δ
components/table/Column.razor 0.00% <0.00%> (ø)
components/table/Column.razor.cs 0.00% <0.00%> (ø)
components/tree/TreeNodeTitle.razor 20.00% <0.00%> (-1.63%) ⬇️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 7af4adc into ant-design-blazor:master Jun 11, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants