fix(module: tree): fix IList DataSource cannot be modify in place
#3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow DataSource to be modify by TreeNode draggable methods.
|
|
|
@dotnet-policy-service agree |
|
Thank you for contribution. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3275 +/- ##
==========================================
- Coverage 45.96% 45.26% -0.70%
==========================================
Files 557 557
Lines 26734 26740 +6
Branches 266 266
==========================================
- Hits 12288 12105 -183
- Misses 14406 14595 +189
Partials 40 40
☔ View full report in Codecov by Sentry. |
Jtfk
changed the title
DataSource cannot be modify in placeDataSource cannot be modify in place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Possible #2896
💡 Background and solution
In #2507,
Tree#DataSourceandTree#ChildrenExpressionare changed toIEnumerablemaking modifying DataSource in place not possible. This issue is currently present in Tree demo draggable page at the time of writing.This PR aims to fix this by skipping
ToList()call when theDataSourceis IList in both TreeNodeChildDataItemsandGetParentChildDataItems.Additionally, some test cases are added to verify it.
📝 Changelog
☑️ Self Check before Merge