fix(module: select): NotifyFieldChanged on null Values #3277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
When making a custom input component that required support for both a single
Value
as well as multipleValues
, I encountered the problem that settingSelectBase
'sValues
to null (in the case I was using only a singleValue
would callNotifyFieldChanged
. Since the field didn't actually change, but the component was rerendered on a validation state change, this resulted in an infinite loop.I added a case for when both
value
and_selectedValues
arenull
, in which caseNotifyFieldChanged
is not called.📝 Changelog
EditContext.NotifyFieldChanged
is no longer called whenValues
is keptnull
.EditContext.NotifyFieldChanged
whenSelectBase.Values
is set (unchanged) to null☑️ Self Check before Merge