Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: core): remove the shared event subscriptions from it's store after there are no one are listening the event #3278

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3184

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English remove the shared event subscriptions from it's store after there are no one are listening the event
🇨🇳 Chinese 修复 DomEventListener 移除不再订阅共享事件的事件列表,避免再次订阅时没创新事件监听器

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

…ore after there are no one are listening the event
@github-actions
Copy link

github-actions bot commented May 31, 2023

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 26.66% and project coverage change: -0.66 ⚠️

Comparison is base (4fcfc02) 45.96% compared to head (6f13e39) 45.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3278      +/-   ##
==========================================
- Coverage   45.96%   45.30%   -0.66%     
==========================================
  Files         557      557              
  Lines       26734    26732       -2     
  Branches      266      266              
==========================================
- Hits        12288    12112     -176     
- Misses      14406    14580     +174     
  Partials       40       40              
Impacted Files Coverage Δ
components/core/JsInterop/DomEventListener.cs 0.00% <0.00%> (ø)
components/table/Table.razor 0.00% <0.00%> (ø)
components/table/Table.razor.cs 0.00% <ø> (ø)
components/tree/TreeNode.razor.cs 27.43% <80.00%> (+27.43%) ⬆️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 69d8cb0 into master Jun 4, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/dom-event-listener-dispose-shared branch June 4, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider does not work when page change!
1 participant