Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): empty status position incorrectly during pre-rendering stage, and avoid unnecessary use of ResizeObserver #3281

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

ElderJames
Copy link
Member

…ering stage, and avoid unnecessary use of ResizeObserver

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3273

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

…ering stage, and avoid unnecessary use of ResizeObserver
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.45 ⚠️

Comparison is base (4fcfc02) 45.96% compared to head (9d21309) 44.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3281      +/-   ##
==========================================
- Coverage   45.96%   44.52%   -1.45%     
==========================================
  Files         557      557              
  Lines       26734    26728       -6     
  Branches      266      266              
==========================================
- Hits        12288    11900     -388     
- Misses      14406    14788     +382     
  Partials       40       40              
Impacted Files Coverage Δ
components/table/Table.razor 0.00% <0.00%> (ø)
components/table/Table.razor.cs 0.00% <ø> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 1f9c539 into master Jun 4, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/table-scrollx-empty branch June 4, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table empty data loading style show not good
1 participant