Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: table): the items of DataSource support interface types #3297

Merged
merged 4 commits into from
Jun 11, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #1026

💡 Background and solution

Due to the limitations of our design, context.Property is used to bind the data, but this requires access to the instance reference.

Finally, we fixed the problem by using DispatchProxy to create instances of the interface.

📝 Changelog

Language Changelog
🇺🇸 English Add Table the items of DataSource support interface types
🇨🇳 Chinese 增加 Table 支持接口类型的 DataSource 子项

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jun 11, 2023

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (61bfb03) 45.27% compared to head (55f6127) 45.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
- Coverage   45.27%   45.25%   -0.03%     
==========================================
  Files         557      558       +1     
  Lines       26725    26732       +7     
  Branches      266      266              
==========================================
- Hits        12100    12097       -3     
- Misses      14585    14595      +10     
  Partials       40       40              
Impacted Files Coverage Δ
components/table/Column.razor 0.00% <0.00%> (ø)
components/table/Column.razor.cs 0.00% <0.00%> (ø)
components/table/Internal/TItemProxy.cs 0.00% <0.00%> (ø)
components/table/Table.razor.cs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit da7e494 into master Jun 11, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/table-interface-datasource branch June 11, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table does not work when item type is an interface
1 participant