Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: modal): add horizontal resizable #3311

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

zxyao145
Copy link
Member

@zxyao145 zxyao145 commented Jun 18, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#3263

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: add resizable paramter for modal, and modal can be resized horizontally
fix: the class and id parameters are not valid in modal component usage
🇨🇳 Chinese Modal 组件新增resizable 参数,允许水平方向对modal进行宽度调整
修复 modal 在组件用法中 id 和 class 参数不生效的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jun 18, 2023

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (ec353de) 46.75% compared to head (e39b341) 46.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3311      +/-   ##
==========================================
- Coverage   46.75%   46.71%   -0.05%     
==========================================
  Files         558      558              
  Lines       26729    26738       +9     
  Branches      266      266              
==========================================
- Hits        12498    12490       -8     
- Misses      14191    14208      +17     
  Partials       40       40              
Impacted Files Coverage Δ
components/modal/config/DialogOptions.cs 0.00% <0.00%> (ø)
components/modal/config/ModalOptions.cs 0.00% <0.00%> (ø)
components/modal/confirmDialog/Confirm.razor 0.00% <ø> (ø)
components/modal/core/Dialog.razor 0.00% <0.00%> (ø)
components/modal/core/Dialog.razor.cs 0.00% <0.00%> (ø)
components/modal/core/DialogWrapper.razor 0.00% <ø> (ø)
components/modal/modalDialog/Modal.razor 0.00% <ø> (ø)
components/modal/modalDialog/Modal.razor.cs 0.00% <0.00%> (ø)
components/modal/modalDialog/ModalContainer.razor 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zxyao145 zxyao145 requested a review from ElderJames June 19, 2023 01:41
@ElderJames ElderJames changed the base branch from master to feature July 5, 2023 14:52
@ElderJames ElderJames linked an issue Jul 5, 2023 that may be closed by this pull request
@ElderJames ElderJames changed the title feat(module: modal): add resizable feat(module: modal): add horizontal resizable Aug 19, 2023
@ElderJames ElderJames merged commit 4c93480 into ant-design-blazor:feature Aug 19, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal set class , Id
2 participants