Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: drawer): add VisibleChanged for two-way binding support #3333

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add Drawer parameter VisibleChanged for two-way binding support
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 6.18% and project coverage change: -0.15% ⚠️

Comparison is base (4fafd9c) 45.37% compared to head (2db0803) 45.22%.
Report is 1 commits behind head on feature.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #3333      +/-   ##
===========================================
- Coverage    45.37%   45.22%   -0.15%     
===========================================
  Files          558      558              
  Lines        26861    26949      +88     
  Branches       267      267              
===========================================
  Hits         12187    12187              
- Misses       14634    14722      +88     
  Partials        40       40              
Files Changed Coverage Δ
components/collapse/Panel.razor 0.00% <0.00%> (ø)
components/collapse/Panel.razor.cs 0.00% <0.00%> (ø)
components/drawer/Drawer.razor.cs 89.87% <75.00%> (-1.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit f9b8800 into feature Aug 15, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the feat/drawer-visible-changed branch August 15, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant