Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: tabs): add keepalive parameter to choose whether to keep the page state #3334

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

closes #3290

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add reusetabs KeepAlive parameter to choose whether to keep the page state
🇨🇳 Chinese 增加 ReuseTabs KeepAlive属性,表示是否保持 Tab 页面的状态

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.44 🎉

Comparison is base (8369c9a) 45.27% compared to head (a078037) 46.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #3334      +/-   ##
===========================================
+ Coverage    45.27%   46.71%   +1.44%     
===========================================
  Files          558      558              
  Lines        26735    26728       -7     
  Branches       266      266              
===========================================
+ Hits         12103    12485     +382     
+ Misses       14592    14203     -389     
  Partials        40       40              
Impacted Files Coverage Δ
components/tabs/Reuse/ReuseTabs.razor 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabs.razor.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsPageAttribute.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsPageItem.cs 0.00% <0.00%> (ø)

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames linked an issue Jul 4, 2023 that may be closed by this pull request
@ElderJames ElderJames merged commit 677b3dd into feature Jul 30, 2023
5 of 6 checks passed
@ElderJames ElderJames deleted the feat/reusetabs-keepalive branch July 30, 2023 09:32
ElderJames added a commit that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReuseTabsPage can keepalive point page not all?
1 participant