Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: tabs): add order options for pinned tabs in reusetabs #3335

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add order options for pinned tabs in reusetabs
🇨🇳 Chinese 增加 Order 指定特殊标签的顺序

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch coverage: 48.75% and project coverage change: -1.31% ⚠️

Comparison is base (7af4adc) 46.70% compared to head (58e186d) 45.40%.
Report is 36 commits behind head on feature.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #3335      +/-   ##
===========================================
- Coverage    46.70%   45.40%   -1.31%     
===========================================
  Files          557      558       +1     
  Lines        26731    26849     +118     
  Branches       266      267       +1     
===========================================
- Hits         12486    12192     -294     
- Misses       14205    14617     +412     
  Partials        40       40              
Files Changed Coverage Δ
components/card/Card.razor 76.19% <ø> (ø)
components/core/HashCodes/HashCodeExtensions.cs 0.00% <0.00%> (ø)
components/core/HashCodes/HashCodeProvider.cs 0.00% <0.00%> (ø)
components/core/HashCodes/ParameterDescriptor.cs 0.00% <ø> (ø)
components/core/JsInterop/DomEventListener.cs 0.00% <0.00%> (ø)
...s/core/JsInterop/modules/dom/manipulationHelper.ts 13.87% <0.00%> (-0.17%) ⬇️
components/date-picker/DatePicker.razor 77.77% <ø> (ø)
components/date-picker/RangePicker.razor 48.48% <ø> (ø)
components/drawer/DrawerService.cs 0.00% <ø> (ø)
components/slider/Slider.razor.cs 61.59% <0.00%> (-0.43%) ⬇️
... and 29 more

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit e5e8c7d into feature Aug 1, 2023
5 of 6 checks passed
@ElderJames ElderJames deleted the feat/reusetabs-order branch August 1, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant