Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: datepicker): support specific popup placement #3345

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

closes #2689

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a8636ca) 46.83% compared to head (0daf73d) 46.84%.

Additional details and impacted files
@@           Coverage Diff            @@
##           feature    #3345   +/-   ##
========================================
  Coverage    46.83%   46.84%           
========================================
  Files          558      558           
  Lines        26800    26801    +1     
  Branches       267      267           
========================================
+ Hits         12553    12555    +2     
+ Misses       14207    14206    -1     
  Partials        40       40           
Impacted Files Coverage Δ
components/date-picker/DatePicker.razor 77.77% <ø> (ø)
components/date-picker/RangePicker.razor 48.48% <ø> (ø)
components/date-picker/internal/DatePickerBase.cs 79.46% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit fbd9b46 into feature Jul 9, 2023
6 checks passed
@ElderJames ElderJames deleted the feat/datepicker-placement branch July 9, 2023 10:21
ElderJames added a commit that referenced this pull request Jul 31, 2023
* feat(module: datepicker): support specific popup placement

* remove tsx
ElderJames added a commit that referenced this pull request Aug 5, 2023
…tes which contains parameters (#3363)

* feat(module: datepicker): support specific popup placement (#3345)

* feat(module: datepicker): support specific popup placement

* remove tsx

* feat(module: tabs): ReuseTabs support specific the PinUrl for the routes which contains parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant