Icon role update #3370
Merged
Icon role update #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(module: tabs): throwing navigate exceptiion while base path was s…
…t change default behavior when a screen reader parses an icon, it sees the role attribute has a value of 'img'. in the case where we don't want the screen reader to read the icon, the role can be assigned a blank value and the role attribute will not be added. instead, the aria-hidden attribute will be added with a value of 'true' no breaking changes
|
|
|
@dotnet-policy-service agree company="Parallon" |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3370 +/- ##
==========================================
+ Coverage 46.80% 46.83% +0.03%
==========================================
Files 558 558
Lines 26824 26832 +8
Branches 267 267
==========================================
+ Hits 12554 12567 +13
+ Misses 14230 14225 -5
Partials 40 40
☔ View full report in Codecov by Sentry. |
ElderJames
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Thank you @eizzn . Could you please help us improve the accessibility of this component library?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge