Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:selectbase): add AutoFocus to select base component #3375

Merged

Conversation

LuukGlorie
Copy link
Contributor

Add AutoFocus to select components to provide same functionalty as other input components

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

To extend support for auto focus across more input components.

📝 Changelog

Add AutoFocus parameter for all components based on SelectBase

Language Changelog
🇺🇸 English AutoFocus for all select components
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Add AutoFocus to select components to provide same functionalty as other input components
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

@LuukGlorie
Copy link
Contributor Author

@ElderJames Not sure though if the OnFocus event should be raised when the component is autofocused?

@LuukGlorie LuukGlorie marked this pull request as ready for review July 27, 2023 06:59
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (a49127c) 46.83% compared to head (21db10d) 46.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3375      +/-   ##
==========================================
+ Coverage   46.83%   46.85%   +0.01%     
==========================================
  Files         558      558              
  Lines       26831    26836       +5     
  Branches      267      267              
==========================================
+ Hits        12567    12573       +6     
+ Misses      14224    14223       -1     
  Partials       40       40              
Files Changed Coverage Δ
components/select/SelectBase.cs 76.45% <100.00%> (+0.31%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames
Copy link
Member

@LuukGlorie I think so. BTW, could we consider putting AutoFocus in the InputComponentBase?

@LuukGlorie
Copy link
Contributor Author

@ElderJames I think that could be an option. You have to know what element reference to focus on, which is not yet available in the InputComponentBase I think. It is quite a breaking change to add an abstract method to that base class.

@ElderJames ElderJames merged commit ed68adf into ant-design-blazor:master Jul 27, 2023
9 checks passed
@LuukGlorie LuukGlorie deleted the feat/select-auto-focus branch July 27, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants