Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:input): when input fails validation, add the aria-invalid… #3378

Merged
merged 4 commits into from
Aug 5, 2023

Conversation

eizzn
Copy link
Contributor

@eizzn eizzn commented Jul 28, 2023

… attribute

when an input fails validation, the aria-invalid attribute is added for accessibility

no breaking changes

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

… attribute

when an input fails validation, the aria-invalid attribute is added for accessibility

no breaking changes
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

@ElderJames
Copy link
Member

Hello @eizzn , please fix the test.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (33816a1) 46.84% compared to head (69f086a) 46.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3378   +/-   ##
=======================================
  Coverage   46.84%   46.84%           
=======================================
  Files         558      558           
  Lines       26844    26848    +4     
  Branches      268      268           
=======================================
+ Hits        12575    12577    +2     
- Misses      14229    14231    +2     
  Partials       40       40           
Files Changed Coverage Δ
components/input/Input.cs 68.15% <80.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit b5ff091 into ant-design-blazor:master Aug 5, 2023
6 checks passed
@eizzn eizzn deleted the aria-invalid-text-input branch August 7, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants