Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: input): null check for the js of textarea resizable #3382

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • [x ] Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3154

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Prepare preview

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.15% 🎉

Comparison is base (c5ced68) 45.68% compared to head (fa9540e) 46.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
+ Coverage   45.68%   46.84%   +1.15%     
==========================================
  Files         558      558              
  Lines       27090    26844     -246     
  Branches      267      268       +1     
==========================================
+ Hits        12377    12574     +197     
+ Misses      14673    14230     -443     
  Partials       40       40              
Files Changed Coverage Δ
...s/core/JsInterop/modules/components/inputHelper.ts 0.00% <0.00%> (ø)

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 33816a1 into master Aug 1, 2023
5 of 6 checks passed
@ElderJames ElderJames deleted the fix/textarea-null-check branch August 1, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of null (reading 'lineHeight') at r.resizeTextArea
1 participant