Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: image): add drag and drop for preview images #3394

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

llp1520
Copy link
Contributor

@llp1520 llp1520 commented Aug 18, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (8e60219) 1.53% compared to head (a694dea) 46.79%.

❗ Current head a694dea differs from pull request most recent head 987a997. Consider uploading reports for the commit 987a997 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           feature    #3394       +/-   ##
============================================
+ Coverage     1.53%   46.79%   +45.25%     
============================================
  Files          559      561        +2     
  Lines        27115    26888      -227     
  Branches       276      272        -4     
============================================
+ Hits           417    12581    +12164     
+ Misses       26658    14267    -12391     
  Partials        40       40               
Files Coverage Δ
components/image/Image.razor.cs 0.00% <ø> (ø)
components/select/internal/SelectContent.razor 61.81% <ø> (+61.81%) ⬆️
...mponents/select/internal/SelectSuffixIcon.razor.cs 100.00% <100.00%> (ø)
components/checkbox/Checkbox.razor 75.00% <50.00%> (+75.00%) ⬆️
components/core/JsInterop/interop.ts 0.00% <0.00%> (ø)
components/table/Selection.razor.cs 0.00% <0.00%> (ø)
components/core/JsInterop/JSInteropConstants.cs 40.74% <0.00%> (+40.74%) ⬆️
components/image/ImagePreview.razor 0.00% <0.00%> (ø)
components/select/internal/SelectSuffixIcon.razor 81.81% <81.81%> (ø)
components/image/ImagePreview.razor.cs 0.00% <0.00%> (ø)
... and 1 more

... and 273 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames changed the title Llp/antdesign blazor feat(module: image): add drag and drop for preview images Oct 10, 2023
@llp1520
Copy link
Contributor Author

llp1520 commented Oct 10, 2023

@dotnet-policy-service agree

@ElderJames ElderJames changed the base branch from master to feature October 10, 2023 22:54
@ElderJames ElderJames merged commit 0508222 into ant-design-blazor:feature Oct 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants