Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: menu): add submenu collapse montion #3395

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 289 lines in your changes are missing coverage. Please review.

Comparison is base (7af4adc) 46.70% compared to head (ade517e) 44.31%.
Report is 114 commits behind head on feature.

Files Patch % Lines
components/collapse/Panel.razor.cs 0.00% 88 Missing ⚠️
components/menu/SubMenu.razor.cs 10.38% 67 Missing and 2 partials ⚠️
components/statistic/CountDown.razor.cs 0.00% 23 Missing ⚠️
components/tree/TreeNode.razor.cs 0.00% 19 Missing ⚠️
components/menu/MenuItem.razor.cs 12.50% 3 Missing and 11 partials ⚠️
components/tree/Tree.razor.cs 36.36% 13 Missing and 1 partial ⚠️
components/input/TextArea.razor.cs 16.66% 6 Missing and 4 partials ⚠️
components/slider/Slider.razor.cs 0.00% 6 Missing ⚠️
components/core/HashCodes/HashCodeProvider.cs 0.00% 5 Missing ⚠️
components/menu/MenuItem.razor 72.22% 3 Missing and 2 partials ⚠️
... and 18 more
Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #3395      +/-   ##
===========================================
- Coverage    46.70%   44.31%   -2.40%     
===========================================
  Files          557      572      +15     
  Lines        26731    27332     +601     
  Branches       266     5615    +5349     
===========================================
- Hits         12486    12111     -375     
- Misses       14205    14240      +35     
- Partials        40      981     +941     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit b5bd189 into feature Dec 24, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the feat/menu-collapse-motion branch December 24, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant