Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): reset PageIndex when filters and sorters change #3397

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2621

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.43% 🎉

Comparison is base (511d904) 45.41% compared to head (02d4c44) 46.84%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3397      +/-   ##
==========================================
+ Coverage   45.41%   46.84%   +1.43%     
==========================================
  Files         558      558              
  Lines       26854    26850       -4     
  Branches      268      268              
==========================================
+ Hits        12196    12579     +383     
+ Misses      14618    14231     -387     
  Partials       40       40              
Files Changed Coverage Δ
components/progress/Progress.razor 0.00% <0.00%> (ø)
components/progress/Progress.razor.cs 0.00% <0.00%> (ø)
components/progress/ProgressEnum.cs 0.00% <0.00%> (ø)
components/select/SelectOption.razor 85.71% <ø> (ø)
components/table/Column.razor.cs 0.00% <0.00%> (ø)
components/table/Table.razor.cs 0.00% <0.00%> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit b5df6d5 into master Aug 22, 2023
5 of 6 checks passed
@ElderJames ElderJames deleted the fix/filter-sorter-reload branch August 22, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table - reset PageIndex when filters change
1 participant