Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: Modal): centered conflict maximizable style #3403

Conversation

zxyao145
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#3401

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: centered conflict maximizable style
🇨🇳 Chinese 修复 centered 和 maximizable 样式冲突

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 26, 2023

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.45% 🎉

Comparison is base (b5df6d5) 45.41% compared to head (e150c1e) 46.86%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3403      +/-   ##
==========================================
+ Coverage   45.41%   46.86%   +1.45%     
==========================================
  Files         558      558              
  Lines       26853    26843      -10     
  Branches      268      268              
==========================================
+ Hits        12194    12580     +386     
+ Misses      14619    14223     -396     
  Partials       40       40              
Files Changed Coverage Δ
components/modal/config/DialogOptions.cs 0.00% <0.00%> (ø)
components/modal/core/Dialog.razor 0.00% <0.00%> (ø)
components/modal/core/Dialog.razor.cs 0.00% <0.00%> (ø)
components/notification/Notification.razor.cs 0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 1915f6c into ant-design-blazor:master Sep 3, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants