Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: localization support,use 'DisplayAttribute.GetName()' method 。 #3426

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

huhangfei
Copy link
Contributor

@huhangfei huhangfei commented Sep 14, 2023

🤔 This is a ...

  • New feature
  • [√] Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

@ElderJames
Copy link
Member

Thanks for contribution @huhangfei , please sign the CLA first.

@huhangfei
Copy link
Contributor Author

@huhangfei please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@ElderJames
Copy link
Member

Thanks @huhangfei , could you please add some tests for that?

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f301bea) 46.92% compared to head (85f02ba) 46.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3426      +/-   ##
==========================================
- Coverage   46.92%   46.89%   -0.03%     
==========================================
  Files         560      560              
  Lines       26852    26845       -7     
  Branches      268      268              
==========================================
- Hits        12601    12590      -11     
- Misses      14211    14215       +4     
  Partials       40       40              
Files Coverage Δ
components/core/Reflection/PropertyReflector.cs 83.33% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 22c60b4 into ant-design-blazor:master Oct 14, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants