Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: watermark): add new component WaterMark #3441

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ElderJames
Copy link
Member

@ElderJames ElderJames commented Sep 23, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3440
fixed #3442
fixed #3500

💡 Background and solution

We haven't implement the cssinjs where the antd 5.x used, so this component's style is not the same with antd.

📝 Changelog

Language Changelog
🇺🇸 English add new component WaterMark
🇨🇳 Chinese 新增水印组件

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 23, 2023

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 174 lines in your changes are missing coverage. Please review.

Comparison is base (c9d95e3) 1.55% compared to head (29591f5) 43.88%.

Additional details and impacted files
@@             Coverage Diff              @@
##           feature    #3441       +/-   ##
============================================
+ Coverage     1.55%   43.88%   +42.33%     
============================================
  Files          567      570        +3     
  Lines        26814    27050      +236     
  Branches      5532     5570       +38     
============================================
+ Hits           417    11871    +11454     
+ Misses       26357    14203    -12154     
- Partials        40      976      +936     
Files Coverage Δ
components/core/JsInterop/interop.ts 0.00% <ø> (ø)
components/core/JsInterop/JSInteropConstants.cs 40.44% <0.00%> (+40.44%) ⬆️
components/watermark/Watermark.razor 0.00% <0.00%> (ø)
...re/JsInterop/modules/components/watermarkHelper.ts 0.00% <0.00%> (ø)
components/watermark/Watermark.razor.cs 0.00% <0.00%> (ø)

... and 256 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames linked an issue Nov 8, 2023 that may be closed by this pull request
@ElderJames ElderJames merged commit 4202866 into feature Nov 15, 2023
5 of 6 checks passed
@ElderJames ElderJames deleted the feat/watermark branch November 15, 2023 16:26
@codeox-he
Copy link

This is really great! Thank you for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Want to support watermark component Add Component [WaterMark] Want to support watermark component
2 participants