feat(module: datepicker): Add DateTimeOffset, DateOnly, TimeOnly support #3443
Conversation
|
|
Alexbits
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature #3443 +/- ##
============================================
+ Coverage 1.56% 47.55% +45.99%
============================================
Files 563 564 +1
Lines 26692 26831 +139
Branches 280 280
============================================
+ Hits 417 12759 +12342
+ Misses 26235 14032 -12203
Partials 40 40
☔ View full report in Codecov by Sentry. |
add(module:datepicker): generic OnPanelChange event add(module:datepicker): generic OnChange event fix(module:datepicker): DateTimeKind is not preserved add(module:datepicker): DateTimeOffset unit tests add(module:datepicker): add DateTimeOffset to range picker unit tests add(module:datepicker): refactor unit tests fix(module:datepicker): DateTime.Kind is not preserved feat(module: datepicker). Add DateTimeOffset, DateOnly, TimeOnly support
ElderJames
force-pushed
the
feat/date_picker_datetimeoffset
branch
from
f3f2466
to
b0144ff
Compare
|
Hello @Alexbits , I have fix the conflicts but there still are a test case is failed. Could you please fix it? |
@ElderJames The Mask feature broke the RangePicker keyed input. There are issues in multiple places. Some of the changes do look absurd to me. |
|
Hey @ElderJames, I've fixed the unit test issues. Some merged changes still look weird to me 🤷🏻♂️. But I do not have time to delve into them at the moment. |
|
Thank you @Alexbits , I will continue to review thoes changes. I'm sorry I may have interfered with your efforts with this component. |
🤔 This is a ...
🔗 Related issue link
#1236
#1589
💡 Background and solution
Allows to use the DateTimeOffset in DatePicker/RangePicker.
📝 Changelog
Adds DateTimeOffset, DateOnly, and TimeOnly support to DatePicker, RangePicker, and TimePicker.
☑️ Self Check before Merge