Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: ReuseTabs): support separate the tab from the page #3467

Merged
merged 6 commits into from
Oct 29, 2023

Conversation

ElderJames
Copy link
Member

@ElderJames ElderJames commented Oct 25, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English support separate the tab from the page, also page reloading
🇨🇳 Chinese 支持拆分标签和页面,并支持页面刷新

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 148 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feature@6b0a8f4). Click here to learn what that means.
Report is 13 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff             @@
##             feature    #3467   +/-   ##
==========================================
  Coverage           ?   44.21%           
==========================================
  Files              ?      567           
  Lines              ?    26876           
  Branches           ?     5554           
==========================================
  Hits               ?    11884           
  Misses             ?    14020           
  Partials           ?      972           
Files Coverage Δ
...nts/core/Extensions/ServiceCollectionExtensions.cs 96.15% <100.00%> (ø)
components/tabs/Reuse/ReuseTabs.razor 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabs.razor.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReusePages.razor 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsService.cs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit c9d95e3 into feature Oct 29, 2023
6 checks passed
@ElderJames ElderJames deleted the refactor/reuse-tabs-pages branch October 29, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant