Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): setup RowKey EqualityComparer for caches #3483

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2837

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Nov 2, 2023

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5118d1d) 44.66% compared to head (6e9a2e6) 1.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #3483       +/-   ##
==========================================
- Coverage   44.66%   1.55%   -43.11%     
==========================================
  Files         566     566               
  Lines       26878   26818       -60     
  Branches     5568    5547       -21     
==========================================
- Hits        12004     417    -11587     
- Misses      13895   26361    +12466     
+ Partials      979      40      -939     
Files Coverage Δ
components/table/Table.razor.RowData.cs 0.00% <ø> (ø)
components/table/Table.razor.cs 0.00% <0.00%> (ø)

... and 263 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit eb8295d into master Nov 2, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/table-cache-comparer branch November 2, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant