Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: TreeSelect): value binding on datasource was changed #3492

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3446

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Nov 6, 2023

@ElderJames ElderJames changed the title Fix/tree select/update on datasource changed fix(module: TreeSelect): value binding on datasource was changed Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (dda9cd9) 44.25% compared to head (73e15e9) 44.73%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3492      +/-   ##
==========================================
+ Coverage   44.25%   44.73%   +0.47%     
==========================================
  Files         566      566              
  Lines       26851    26890      +39     
  Branches     5556     5569      +13     
==========================================
+ Hits        11884    12030     +146     
+ Misses      13995    13885     -110     
- Partials      972      975       +3     
Files Coverage Δ
...ponents/core/Extensions/ComponentBaseExtensions.cs 0.00% <ø> (ø)
components/select/SelectBase.cs 68.51% <ø> (ø)
components/tree-select/TreeSelect.razor 0.00% <ø> (ø)
components/tree/TreeNode.razor.cs 20.63% <100.00%> (ø)
components/tree/Tree.razor.cs 27.61% <92.30%> (+3.09%) ⬆️
components/tree-select/TreeSelect.razor.cs 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 6f6b758 into master Nov 7, 2023
6 checks passed
@ElderJames ElderJames deleted the fix/tree-select/update-on-datasource-changed branch November 7, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeSelect Setting the default value when loading data remotely does not show the title
1 participant