-
-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:(module:datepicker): ArgumentOutOfRangeException in TimePicker #3501
fix:(module:datepicker): ArgumentOutOfRangeException in TimePicker #3501
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3501 +/- ##
==========================================
- Coverage 44.57% 1.55% -43.03%
==========================================
Files 566 566
Lines 26934 26899 -35
Branches 5582 5566 -16
==========================================
- Hits 12005 417 -11588
- Misses 13953 26442 +12489
+ Partials 976 40 -936
☔ View full report in Codecov by Sentry. |
Thanks @Alexbits , but I also meet the issue.
|
…om/Alexbits/ant-design-blazor into fix/timeonly_argument_out_of_range
@ElderJames Fixed. DatePicker needs more unit tests... |
You are right @Alexbits . Do you want to add tests in this PR or another one? |
Added basic tests to cover this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤔 This is a ...
🔗 Related issue link
#3498
💡 Background and solution
The ArgumentOutOfRangeException occurs in the TimePicker when internally converting DateTime.MinValue with DateTimeKind.Local to the DateTimeOffset. The solution is to change DateTime.Kind to Unspecified during the conversion.
📝 Changelog
Fixes System.ArgumentOutOfRangeException: The UTC time represented when the offset is applied must be between year 0 and 10,000. (Parameter 'offset') in the TimePicker.
☑️ Self Check before Merge