Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: mentions): Add dynamic async loading of mentions #3503

Conversation

kooliokey
Copy link
Contributor

@kooliokey kooliokey commented Nov 9, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#3261

💡 Background and solution

📝 Changelog

Mentions dynamic async list loading

Language Changelog
🇺🇸 English Add dynamic async loading of mentions
🇨🇳 Chinese 添加提及的动态异步加载

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Nov 9, 2023

@kooliokey kooliokey changed the title Add dynamic async loading of mentions along with more tests. feat(module: mentions): Add dynamic async loading of mentions Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (c9d95e3) 1.55% compared to head (8ffdebe) 1.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           feature   #3503      +/-   ##
==========================================
- Coverage     1.55%   1.55%   -0.01%     
==========================================
  Files          567     568       +1     
  Lines        26814   26829      +15     
  Branches      5532    5532              
==========================================
  Hits           417     417              
- Misses       26357   26372      +15     
  Partials        40      40              
Files Coverage Δ
components/mentions/Mentions.razor 0.00% <0.00%> (ø)
components/mentions/MentionsDynamicOption.cs 0.00% <0.00%> (ø)
components/mentions/Mentions.razor.cs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 161aef5 into ant-design-blazor:feature Nov 9, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants