Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3355 Fixed Selected value will be reset when ValidateOnChange is on #3508

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

ldsenow
Copy link
Contributor

@ldsenow ldsenow commented Nov 13, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Nov 13, 2023

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2b53e61) 1.55% compared to head (fd45d50) 44.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3508       +/-   ##
===========================================
+ Coverage    1.55%   44.64%   +43.09%     
===========================================
  Files         566      566               
  Lines       26899    26961       +62     
  Branches     5566     5588       +22     
===========================================
+ Hits          417    12036    +11619     
+ Misses      26442    13945    -12497     
- Partials       40      980      +940     
Files Coverage Δ
components/select/Select.razor.cs 45.51% <20.00%> (+45.51%) ⬆️

... and 264 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames
Copy link
Member

Thanks @ldsenow , could you add a test case to cover this case?

@ElderJames ElderJames merged commit a2fa9b7 into ant-design-blazor:master Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected value will be reset while the Select control is under FormItem
3 participants