Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tabs): default to open first pinned page with reusetabs #3519

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Nov 18, 2023

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4202866) 44.06% compared to head (65a2049) 44.04%.

Files Patch % Lines
components/tabs/Reuse/ReuseTabsService.cs 0.00% 2 Missing ⚠️
components/tabs/Reuse/ReuseTabsPageAttribute.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #3519      +/-   ##
===========================================
- Coverage    44.06%   44.04%   -0.02%     
===========================================
  Files          571      571              
  Lines        27065    27067       +2     
  Branches      5570     5571       +1     
===========================================
- Hits         11926    11923       -3     
- Misses       14165    14169       +4     
- Partials       974      975       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames changed the title fix(module: tabs): open first page in reusetabs fix(module: tabs): default to open first pinned page with reusetabs Nov 19, 2023
@ElderJames ElderJames merged commit 1ed06b7 into feature Nov 19, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/reuse-tabs-first-page branch November 19, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant