fix(module select): simulate setTimeout, ensure that the click event is processed properly #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zxyao145
force-pushed
the
fix/diff-click-1125
branch
6 times, most recently
from
2111124
to
443f6ea
Compare
zxyao145
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3525 +/- ##
==========================================
- Coverage 44.47% 44.08% -0.40%
==========================================
Files 566 566
Lines 27182 27218 +36
Branches 5577 5583 +6
==========================================
- Hits 12090 11999 -91
- Misses 14101 14233 +132
+ Partials 991 986 -5 ☔ View full report in Codecov by Sentry. |
zxyao145
changed the title
zxyao145
changed the title
ElderJames
reviewed
Nov 26, 2023
| { | ||
| await Task.Delay(4); |
There was a problem hiding this comment.
In JS, 4ms is a better configuration, and I think the same goes for Blazor.
https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#dom-settimeout
|
I found another issue. |
zxyao145
force-pushed
the
fix/diff-click-1125
branch
2 times, most recently
from
8eed893
to
957cfe7
Compare
zxyao145
force-pushed
the
fix/diff-click-1125
branch
from
baba816
to
b3241cf
Compare
zxyao145
force-pushed
the
fix/diff-click-1125
branch
from
b3241cf
to
8785f15
Compare
|
Meet another issue that cause exception after open two filter. |
This have been fixed via #3543 |
ElderJames
reviewed
Dec 21, 2023
ElderJames
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#3521
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge