Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: select): clear selectd option when the default value isn't in the options #3529

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

ElderJames
Copy link
Member

…t in the options

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3527

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Nov 26, 2023

@ElderJames ElderJames changed the title fix(module: select): clear selectd option when the default value isn'… fix(module: select): clear selectd option when the default value isn't in the options Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (b670ee3) 1.55% compared to head (b9e0536) 44.36%.
Report is 9 commits behind head on master.

Files Patch % Lines
...ponents/core/Extensions/ParameterViewExtensions.cs 8.33% 9 Missing and 2 partials ⚠️
components/tree/TreeNode.razor.cs 0.00% 9 Missing and 2 partials ⚠️
components/tree/Tree.razor.cs 33.33% 8 Missing and 2 partials ⚠️
components/select/Select.razor.cs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3529       +/-   ##
===========================================
+ Coverage    1.55%   44.36%   +42.81%     
===========================================
  Files         566      566               
  Lines       26895    27174      +279     
  Branches     5566     5576       +10     
===========================================
+ Hits          417    12056    +11639     
+ Misses      26438    14133    -12305     
- Partials       40      985      +945     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit b25ce24 into master Dec 3, 2023
6 checks passed
@ElderJames ElderJames deleted the fix/select-clear-when-defaultvalue-not-found branch December 3, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can the DefaultValue value of the Select component be displayed as empty if it is not in the data source?
1 participant