Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: core): enum name supports localization #3536

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Nov 29, 2023

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (b670ee3) 1.55% compared to head (ab24747) 44.68%.
Report is 2 commits behind head on master.

Files Patch % Lines
...ponents/core/Extensions/ParameterViewExtensions.cs 8.33% 9 Missing and 2 partials ⚠️
components/tree/TreeNode.razor.cs 0.00% 9 Missing and 2 partials ⚠️
components/tree/Tree.razor.cs 33.33% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3536       +/-   ##
===========================================
+ Coverage    1.55%   44.68%   +43.13%     
===========================================
  Files         566      566               
  Lines       26895    26984       +89     
  Branches     5566     5599       +33     
===========================================
+ Hits          417    12059    +11642     
+ Misses      26438    13944    -12494     
- Partials       40      981      +941     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames enabled auto-merge (squash) November 30, 2023 12:27
@ElderJames ElderJames merged commit 50c1324 into master Nov 30, 2023
6 checks passed
@ElderJames ElderJames deleted the feat/enum-get-name branch November 30, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant