Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: textarea) affix-wrapper-disabled doesn't append #3538

Merged

Conversation

zuevus
Copy link
Contributor

@zuevus zuevus commented Nov 30, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

The TextArea component older then 14-th version of antdesign-blazor has the "affix-wrapper-disabled" class on span element of textarea wrap. It looked like this
image
But at the moment we don't have the class
image
We used it in our project for deactivate the textarea hover.
Solution is to add "affix-wrapper-disabled" class to wrapper span of textarea, as it has already done for inputs(base class) and as it was adding before in yonger then 14-th versions.

📝 Changelog

Language Changelog
🇺🇸 English SetClass method of textarea component adds {PrefixCls}-affix-wrapper-disabled to _warpperClassMapper
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Nov 30, 2023

@zuevus
Copy link
Contributor Author

zuevus commented Nov 30, 2023

@dotnet-policy-service agree

@dotnet-policy-service agree

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (316d0aa) 44.38% compared to head (1d2c9e6) 44.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3538      +/-   ##
==========================================
+ Coverage   44.38%   44.40%   +0.02%     
==========================================
  Files         566      566              
  Lines       27174    27176       +2     
  Branches     5576     5575       -1     
==========================================
+ Hits        12061    12068       +7     
+ Misses      14128    14127       -1     
+ Partials      985      981       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames
Copy link
Member

Thanks for contribution @zuevus , please use GetIf() for the condition.

@ElderJames
Copy link
Member

Thank you @zuevus , would you please add a unit test to cover this?

 * fix: when TextArea in disabled state the "affix-wrapper-disabled"
   didn't append to span
@zuevus zuevus force-pushed the fix/textarea_disabled_state branch 2 times, most recently from 64a8587 to 15d2a90 Compare December 5, 2023 07:47
@zuevus zuevus force-pushed the fix/textarea_disabled_state branch from 15d2a90 to 1d2c9e6 Compare December 5, 2023 07:51
@zuevus
Copy link
Contributor Author

zuevus commented Dec 6, 2023

Thank you @zuevus , would you please add a unit test to cover this?

@ElderJames thanks for comments. I guess I've done everything as you said and debug it. I've checked a test locally for it and pass it. Should I do something more for the issue?

@ElderJames ElderJames merged commit cb47c1a into ant-design-blazor:master Dec 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants