Fix exception when uploading a file without an extension #3554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UploadButton to use System.IO.Path.GetExtension instead of Substring to support filenames without extensions
🤔 This is a ...
🔗 Related issue link
#3553
💡 Background and solution
Uploading a file that does not have a file extension using the Upload[button] component results in the following exception being thrown:
This is happening because the UploadButton component uses Substring based on the position of the last
.
, which is-1
when no.
is present. This PR fixes this by using the built-inSystem.IO.Path.GetExtension
method instead, which better expresses intent and is not affected by this bug.There are no existing test cases covering this code path and I struggled to create one, but would be happy to add one with assistance.📝 Changelog
☑️ Self Check before Merge