Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): can't clear the selected rows if they were not on the current page #3566

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Dec 11, 2023

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (cb47c1a) 44.39% compared to head (9ed4cf1) 1.53%.
Report is 1 commits behind head on master.

Files Patch % Lines
components/table/Table.razor.Selection.cs 0.00% 13 Missing ⚠️
components/upload/UploadButton.razor.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #3566       +/-   ##
==========================================
- Coverage   44.39%   1.53%   -42.86%     
==========================================
  Files         566     566               
  Lines       27176   27119       -57     
  Branches     5575    5556       -19     
==========================================
- Hits        12065     417    -11648     
- Misses      14128   26662    +12534     
+ Partials      983      40      -943     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit a049dcb into master Dec 11, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/table-clear-all-selected-rows branch December 11, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant