Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: select): add parameter that support use delegate to set option label and value #3569

Merged

Conversation

MarvelTiter
Copy link
Contributor

@MarvelTiter MarvelTiter commented Dec 12, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

feat: add ValueGetter property to set or get _getValue and LabelGetter property to set or get _getLabel
fix: add parameter (named Item) for SelectOption that should be used when SelectOption was created directly and TItem is different with TItemValue

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

…ould be used when SelectOption was created directly and TItem is different with TItemValue
Copy link

github-actions bot commented Dec 12, 2023

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fd73cc9) 44.09% compared to head (c9d8783) 44.50%.
Report is 5 commits behind head on master.

❗ Current head c9d8783 differs from pull request most recent head a7a8c09. Consider uploading reports for the commit a7a8c09 to get more accurate results

Files Patch % Lines
components/select/Select.razor.cs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3569      +/-   ##
==========================================
+ Coverage   44.09%   44.50%   +0.41%     
==========================================
  Files         566      566              
  Lines       27218    27185      -33     
  Branches     5584     5578       -6     
==========================================
+ Hits        12003    12100      +97     
+ Misses      14231    14096     -135     
- Partials      984      989       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarvelTiter
Copy link
Contributor Author

@MarvelTiter please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@ElderJames ElderJames merged commit 4451315 into ant-design-blazor:master Dec 25, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants