Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): clear the selection state after pages was changed outside #3577

Merged
merged 1 commit into from Dec 19, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Dec 19, 2023

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cb47c1a) 44.39% compared to head (2bb5cb8) 1.53%.
Report is 2 commits behind head on master.

Files Patch % Lines
components/table/Table.razor.cs 0.00% 1 Missing ⚠️
components/upload/UploadButton.razor.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #3577       +/-   ##
==========================================
- Coverage   44.39%   1.53%   -42.86%     
==========================================
  Files         566     566               
  Lines       27176   27120       -56     
  Branches     5575    5556       -19     
==========================================
- Hits        12065     417    -11648     
- Misses      14128   26663    +12535     
+ Partials      983      40      -943     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit d303d9c into master Dec 19, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/table-clear-election-pagechanged-outside branch December 19, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant