Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: input): hide the clear icon when the input was disabled #3585

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3510

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Dec 24, 2023

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (fd73cc9) 44.09% compared to head (25a247c) 1.53%.
Report is 2 commits behind head on master.

Files Patch % Lines
components/collapse/Panel.razor.cs 0.00% 10 Missing ⚠️
components/input/Input.cs 0.00% 3 Missing ⚠️
components/collapse/Collapse.razor.cs 0.00% 1 Missing ⚠️
components/input/TextArea.razor 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #3585       +/-   ##
==========================================
- Coverage   44.09%   1.53%   -42.57%     
==========================================
  Files         566     566               
  Lines       27218   27168       -50     
  Branches     5584    5565       -19     
==========================================
- Hits        12003     417    -11586     
- Misses      14231   26711    +12480     
+ Partials      984      40      -944     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 70212f6 into master Dec 24, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/input-clear-icon-disabled branch December 24, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input box disable has no effect on the Clear button
1 participant