Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): rows can't rerender in some cases #3586

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimizationx
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3555 #3581

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Dec 24, 2023

@ElderJames ElderJames linked an issue Dec 24, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (fd73cc9) 44.09% compared to head (7086041) 44.07%.
Report is 3 commits behind head on master.

Files Patch % Lines
components/collapse/Panel.razor.cs 0.00% 10 Missing ⚠️
components/collapse/Collapse.razor.cs 0.00% 1 Missing ⚠️
components/table/Table.razor 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3586      +/-   ##
==========================================
- Coverage   44.09%   44.07%   -0.03%     
==========================================
  Files         566      566              
  Lines       27218    27238      +20     
  Branches     5584     5587       +3     
==========================================
+ Hits        12003    12004       +1     
- Misses      14231    14249      +18     
- Partials      984      985       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 8d16de6 into master Dec 24, 2023
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/table-rerender branch December 24, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant