Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: radio): add button style support for RadioGroup with opt… #3589

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

ElderJames
Copy link
Member

…ions

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Dec 25, 2023

@ElderJames ElderJames linked an issue Dec 25, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 109 lines in your changes are missing coverage. Please review.

Comparison is base (487cb08) 1.53% compared to head (2c748fa) 44.29%.
Report is 2 commits behind head on feature.

Files Patch % Lines
components/menu/SubMenu.razor.cs 10.38% 67 Missing and 2 partials ⚠️
components/flex/Flex.razor.cs 0.00% 35 Missing ⚠️
components/core/Helpers/CssStyleBuilder.cs 0.00% 1 Missing and 1 partial ⚠️
components/core/CssSizeLength.cs 0.00% 1 Missing ⚠️
components/radio/RadioGroup.razor 50.00% 1 Missing ⚠️
components/radio/RadioGroup.razor.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           feature    #3589       +/-   ##
============================================
+ Coverage     1.53%   44.29%   +42.75%     
============================================
  Files          571      572        +1     
  Lines        27154    27333      +179     
  Branches      5588     5617       +29     
============================================
+ Hits           417    12107    +11690     
+ Misses       26697    14244    -12453     
- Partials        40      982      +942     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit a790691 into feature Dec 25, 2023
6 checks passed
@ElderJames ElderJames deleted the feat/radio-group-button branch December 25, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnumRadioGroup
1 participant