Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: menu): wrong judge #3614

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3604

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Jan 6, 2024

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6a4147a) 43.58% compared to head (ff5e675) 43.64%.

Files Patch % Lines
components/menu/Menu.razor.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3614      +/-   ##
==========================================
+ Coverage   43.58%   43.64%   +0.05%     
==========================================
  Files         572      572              
  Lines       27628    27628              
  Branches     5617     5617              
==========================================
+ Hits        12042    12057      +15     
+ Misses      14591    14580      -11     
+ Partials      995      991       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 8726233 into master Jan 7, 2024
5 of 6 checks passed
@ElderJames ElderJames deleted the fix/menu-inline-collapsed-exception branch January 7, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu inlinemode InlineCollected Conflict
1 participant